New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FJ_CRE_VALIDITY and FJ_CRE_REINDEX should be defined as proper functions #182
Comments
Just to clarify further: If you run the following mod
you will get this message: |
Will fix. |
To be precise, the same holds for
you will get the aforementioned error because variables like Anyway, the situation is different this time because you cannot know a priori how many vertices you are going to define. As a result, it would be better to edit documentation in order to state that such variables are NOT part of function definition and must be defined before launching
|
Done in 9a51c33. This is not backward-compatible with
which did work before but will not work after this change. Possibly a better solution would have been do declare a new interface and deprecate the old one. |
So I did change my mind, reverted 9a51c33 and added wrapper functions instead. |
Doc states that these functions can take some variables like
do_message
,do_reindex
, etc.But if you look at how these functions have been defined (here), you'll notice they can take no variables (i.e.,
do_message
,do_reindex
and the like are not local to the functions).I suggest to code them as proper functions (even if the final result is the same). So if we consider
FJ_CRE_VALIDITY
as an example:The text was updated successfully, but these errors were encountered: