Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning once is not enough #19

Closed
WenjieZ opened this issue Mar 17, 2021 · 1 comment
Closed

Warning once is not enough #19

WenjieZ opened this issue Mar 17, 2021 · 1 comment
Assignees
@WenjieZ

Comments

@WenjieZ
Copy link
Owner

WenjieZ commented Mar 17, 2021

TSCV/tscv/split.py

Line 253 in f8b832f

warnings.warn(SINGLETON_WARNING, Warning)

This warning should appear for every occurrence. Use standard output instead.
@WenjieZ WenjieZ added this to the v0.0.5 milestone Mar 17, 2021
@WenjieZ WenjieZ self-assigned this Mar 17, 2021
@WenjieZ
Copy link
Owner Author

WenjieZ commented Mar 17, 2021

Technical difficulty: since both the training sets and the test sets are computed (from the _iter_test_indices), the singleton warning will appear for twice rather than the desired once.

@WenjieZ WenjieZ removed this from the v0.0.5 milestone Mar 17, 2021
@WenjieZ WenjieZ mentioned this issue Mar 17, 2021
Closed
@WenjieZ WenjieZ closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WenjieZ WenjieZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transform singleton warning to standard output (fix #19) WenjieZ/TSCV
1 participant
@WenjieZ