Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Need to add tool for Crash Reporting & Analytics #15

Closed
maks opened this issue Mar 22, 2020 · 14 comments · Fixed by #236
Closed

Need to add tool for Crash Reporting & Analytics #15

maks opened this issue Mar 22, 2020 · 14 comments · Fixed by #236
Assignees
Labels
Engineering #3 Priority Lower priority screens and features to work on
Projects
Milestone

Comments

@maks
Copy link
Collaborator

maks commented Mar 22, 2020

I'm familiar with Sentry and it works well for Flutter in prev project so I can set up Sentry account and add to app unless someone else has different preferences?
cc: @workerbee22 @alessandrofavero @adamkoch @domesticmouse

@adamkoch
Copy link
Contributor

adamkoch commented Mar 22, 2020

I've only used Sentry with RN before. It seems good. Other option which I've used with Flutter is Firebase Crashlytics which also works quite well although it has an open where it catches all exceptions as non-fatal (you an still see all the info fine though).

@maks
Copy link
Collaborator Author

maks commented Mar 22, 2020

Thanks @adamkoch . Yes I had lots of trouble last year with crashlytics for Flutter app, so went with Sentry on several apps so far includign a commerical one and works very well.

@adamkoch
Copy link
Contributor

Sentry SGTM

@workerbee22
Copy link
Collaborator

Given we have FB support in the app for FB App Dist ... we could use Crashlytics, but I'm not that wedded to it.

@lukesleeman lukesleeman added this to the Version 3 milestone Mar 29, 2020
@lukesleeman lukesleeman added the #3 Priority Lower priority screens and features to work on label Apr 4, 2020
@workerbee22
Copy link
Collaborator

@maks @lukesleeman @rockgecko-development So this along with analytics can be delayed until just before large beta group. Also expanding the scope of this issue to include analytics. But I think in this case Crashlytics may be the better choice because:

  • google-services already in the app code for iOS and Android
  • Firebase app setup for Android and iOS also already setup in the app and integrated into the app and the Firebase console
  • because of the two above getting setup for iOS and Android should be easy from here
  • Google Analytics also because of above will be easy from here for iOS and Android setup.
  • Firebase console is very 'non tech' friendly and with Crash Reporting + Analytics shown in Firebase console (and more detailed data get shown in Google Analytics console) this makes it kind of a friendly one-stop-shop for Gregg to use later after the app is live.

@workerbee22 workerbee22 changed the title Need to add tool for crash/error reporting Need to add tool for Crash Reporting & Analytics Apr 6, 2020
@maks
Copy link
Collaborator Author

maks commented Apr 6, 2020

There's trade offs on both sides.

My main reasons for suggesting Sentry over Crashlytics:

  • Personal experience in trying to get Crashlytics working on previous commercial Flutter project was absymal
  • Real time data reporting so you don't wait X hours to find out about mass crash spikes
  • Sentry package pure dart so much easier to work with than FB
  • Sentry dashboard much more developer friendly, I don't see the argument for why we need it to be non tech user friendly ? as the specific audience is developers not nontech project users
  • Subjectively I've found quality and stability of Sentry dart package much better than FB Crashlytics one

So we need to balance all the pros for FB in Mike's comment with the above and try to come up with our preferred option.

@workerbee22
Copy link
Collaborator

Ok we need to make a decision at some point. Sentry wise yep I like too and is a friendly console too.

But I also have Crashlytics working on Android and iOS in multiple projects and didn't see big issues. Reporting is also not that long ... from memory it like 10s of minutes not hours to report to console.

@maks do we know how good Sentry is with iOS? I've only used on Android.

But how about we vote to make the call?

@maks
Copy link
Collaborator Author

maks commented Apr 7, 2020

I'm ok with Crashlytics as long as I don't have to set it up 😉

But is the error reporting from Flutter not being given error status in Crashlytics still an issue?

Also seems to be problems getting it working properly on iOS: https://stackoverflow.com/q/60111182/85472

@workerbee22
Copy link
Collaborator

I can set it up, given I know it better than most.

That info on crashes not being reported as 'non-fatal' is no longer true. See below:

image

🙈See several 'Crash' status errors reported ... won't show the rest of the list ... lots of Carsh status errors 🙈🤣

See also working on iOS ... but haven't been actively using my iOS apps lately so only 1 crash in console atm. But to confirm I'll go back and simulate the various levels of crashes/errors on iOS just to make sure they all come through 👍

image

There is also a PR in already for the FlutterFire package to migrate over to the NEW Firebase Crashlytics SDK (no more Fabric dependencies etc.) that is currently in Beta. So I'll have a closer look now to update myself first. 👍

@adamkoch
Copy link
Contributor

adamkoch commented Apr 7, 2020

That info on crashes not being reported as 'non-fatal' is no longer true. See below:

Interesting. I've never been able to get it working personally. For reference, the issue is here:
firebase/flutterfire#398

@workerbee22
Copy link
Collaborator

@adamkoch Yeah I might have to update the issue firebase/flutterfire#398 with some 'tricks' I've discovered. But before we finalise Crashlytics wan to do some quick retesting ... just in case.

@workerbee22
Copy link
Collaborator

Here are more examples of crashes:

image

@lukesleeman lukesleeman modified the milestones: Version 3, Version 1 Apr 7, 2020
@adamkoch
Copy link
Contributor

adamkoch commented Apr 7, 2020

@workerbee22 awesome, if you can add more info to the public bug that would be great, then others can also try and get it working 👍

@workerbee22
Copy link
Collaborator

Rechecked Crashlytics and still takes a while for the crashes to hit the console. So will do a combined PR for both of these together.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Engineering #3 Priority Lower priority screens and features to work on
Projects
Kanban
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants