Add separate kotlinx.interval.datetime library
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this is the only way these test sources can be reused by `kotlinx.interval` extensions (https://stackoverflow.com/q/58956010/590790), such as the upcoming `kotlinx.interval.datetime` module.
Whathecode
force-pushed
the
datetime-intervals
branch
from
e0f4e7c
to
68e2e88
Compare
Provide access to `TypeOperations` for `Instant` and `Duration`.
Whathecode
force-pushed
the
datetime-intervals
branch
from
c3d32f9
to
e6efd67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
Turned the main
kotlinx.intervalinto a submodule as part of a multi-module project.To be able to reuse the test base classes from other modules, I moved them to a new submodule
kotlinx.interval.test. Rather than pulling in this dependency in eachkotlinx.intervallibrary, a test dependency to this library should likely be included as part of theinterval.library-conventionsgradle plugin (#14).Next up is adding
kotlinx.interval.datetimewhich definesInterval<Instant, Duration>.