Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor bpaf fixes #4

Closed
wants to merge 2 commits into from
Closed

Some minor bpaf fixes #4

wants to merge 2 commits into from

Conversation

pacak
Copy link
Contributor

@pacak pacak commented Aug 3, 2023

  • elp::args - use flag instead of switch + negate combo
  • add /target to .gitignore

Describe your changes

minor improvements to bpaf code, it should be possible to clean it up more with 0.9 branch - show help by default, etc.


--experimental flag seems a bit strange. Name and help suggest that it will enable experimental diagnostics, while value it produces and how it is later used suggests that experimental diagnostics will be disabled:

crates/elp/src/bin/elp_parse_cli.rs:    cfg.disable_experimental = args.experimental_diags;
crates/elp/src/bin/lint_cli.rs:            cfg.disable_experimental = args.experimental_diags;

@facebook-github-bot
Copy link
Contributor

@alanz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@alanz merged this pull request in 2b07563.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants