Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors on 2018.4.26f1 #38

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

amirebrahimi
Copy link
Contributor

Related issues
Somewhat related to a community contribution to Unity-Technologies/AutoLOD#74

Describe the changes
A few small fixes:

  • GUIDs don't work in 2018 asmdefs
  • TestAssemblies checkbox required for 2018
  • Compile error on 2018

How to test
You can verify with 2018.4.26f1 by editing the manifest.json to pull the package/branch from github or clone locally to Packages/

@Whinarn Whinarn self-assigned this Aug 25, 2020
Copy link
Owner

@Whinarn Whinarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in 2018.4.26f1, 2019.3.15f1 and 2020.1.0f1 without issues.
Thank you for this fix! 👍

@Whinarn Whinarn merged commit 91b5ad7 into Whinarn:master Aug 25, 2020
github-actions bot pushed a commit that referenced this pull request Aug 25, 2020
## [2.3.4](v2.3.3...v2.3.4) (2020-08-25)

### Bug Fixes

* **tests:** compile errors on 2018.4.26f1 ([#38](#38)) ([91b5ad7](91b5ad7))
@github-actions
Copy link

🎉 This PR is included in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to Hengle/UnityMeshSimplifier that referenced this pull request Nov 18, 2023
# [2.0.0](v1.0.2...v2.0.0) (2023-11-18)

### Bug Fixes

* **lod-generator-helper:** mark scene as dirty ([7554f8e](7554f8e))
* **lods:** prevent empty mesh names ([ec6cf87](ec6cf87))
* **mesh:** bug related to degenerated triangle when using smart linking ([e9d5def](e9d5def))
* **meshutils:** GetUsedUVComponents should now be able to return zero ([af60914](af60914))
* **simplifier:** obsolete properties that moved to options struct ([84664d1](84664d1))
* **simplifier:** options for uv component count ([7f7b773](7f7b773))
* **simplifier:** prevent near zero denominator ([469272a](469272a))
* **simplifier:** removed obsolete properties ([24ccc56](24ccc56))
* support Unity 2021 ([2f2eb3b](2f2eb3b))
* **tests:** compile errors on 2018.4.26f1 ([Whinarn#38](https://github.com/Hengle/UnityMeshSimplifier/issues/38)) ([91b5ad7](91b5ad7))
* **unity:** increase support for unity 2020 ([7a28614](7a28614))

### Features

* **lods:** save assets path is now less restricted ([380bda9](380bda9))
* **package:** bump minimum required version of Unity to 2018.1 ([8f37f81](8f37f81))
* **simplifier:** added options validation ([55264ce](55264ce))
* **simplifier:** set manual uv component count ([9795860](9795860))

### Reverts

* temporarily allow refactor commits to trigger a release ([fd8d697](fd8d697))

### BREAKING CHANGES

* **simplifier:** removed obsolete properties
* **lods:** save assets paths are now related to Assets/ rather
than Assets/UMS_LODS/
github-actions bot pushed a commit to kaneleka/UnityMeshSimplifier that referenced this pull request Feb 8, 2024
# [3.0.0](v2.0.1...v3.0.0) (2024-02-08)

### Bug Fixes

* **lod-generator-helper:** mark scene as dirty ([7554f8e](7554f8e))
* **lods:** prevent empty mesh names ([ec6cf87](ec6cf87))
* **mesh:** bug related to degenerated triangle when using smart linking ([e9d5def](e9d5def))
* **meshutils:** GetUsedUVComponents should now be able to return zero ([af60914](af60914))
* **simplifier:** obsolete properties that moved to options struct ([84664d1](84664d1))
* **simplifier:** options for uv component count ([7f7b773](7f7b773))
* **simplifier:** prevent near zero denominator ([469272a](469272a))
* **simplifier:** removed obsolete properties ([24ccc56](24ccc56))
* support Unity 2021 ([2f2eb3b](2f2eb3b))
* **tests:** compile errors on 2018.4.26f1 ([Whinarn#38](https://github.com/kaneleka/UnityMeshSimplifier/issues/38)) ([91b5ad7](91b5ad7))
* **unity:** increase support for unity 2020 ([7a28614](7a28614))

### Features

* **lods:** save assets path is now less restricted ([380bda9](380bda9))
* **package:** bump minimum required version of Unity to 2018.1 ([8f37f81](8f37f81))
* **simplifier:** added options validation ([55264ce](55264ce))
* **simplifier:** set manual uv component count ([9795860](9795860))

### Reverts

* temporarily allow refactor commits to trigger a release ([fd8d697](fd8d697))

### BREAKING CHANGES

* **simplifier:** removed obsolete properties
* **lods:** save assets paths are now related to Assets/ rather
than Assets/UMS_LODS/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants