Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(whirl_server): Distributor and Hub freak out on malformed packet (s) #67

Open
Fuwn opened this issue Aug 6, 2021 · 1 comment
Open
Labels
bug Something isn't working

Comments

@Fuwn
Copy link
Member

Fuwn commented Aug 6, 2021

Describe the bug
When the Distributor or Hub receives a malformed packet, it goes insane and panics.

To Reproduce
Steps to reproduce the behavior:

  1. Startup WhirlServer
  2. Navigate to http://localhost:6650 via an HTTP client
  3. Observe error

Expected behavior
The WhirlServer ignores the malformed packet.

@Fuwn Fuwn added the bug Something isn't working label Aug 6, 2021
@Fuwn
Copy link
Member Author

Fuwn commented Jan 12, 2022

This will be relatively easy to fix: if the third byte is not one of the predefined packet types, ignore the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant