Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct audio capture #3563

Closed
mcginty opened this issue Jul 8, 2015 · 19 comments
Closed

Direct audio capture #3563

mcginty opened this issue Jul 8, 2015 · 19 comments
Assignees
Labels
Milestone

Comments

@mcginty
Copy link
Contributor

mcginty commented Jul 8, 2015

Push-to-talk style.

spawned from #520

@cherryasphalt
Copy link
Contributor

Do you see this being part of the same drawer as the direct image capture or a separate component (sort of like WhatsApp?)

@derfasthirnlosenick
Copy link

Judging from how I've observed a 12 y.o. Teenager using this feature in whatsapp, the sheer number of messages sent hints to a need for quite direct access. I.e. not a drawer.

How about as an alternative mode of selecting (in addition to the standard drawer), we get a press-and-hold circular "menu" like paranoid android has/had, just with Material style floating buttons. Due to the location of the attach button, we'd probably need two levels as the first one can only accommodate three icons. I guess Camera, Microphone and File/other might be a good choice. And behind File/other you hide File (in the same level so that it's one swiping motion), Location and the others. Whether it would be good to put Picture and Video behind the camera one, I do not know.

@Thunderpig72
Copy link

Telegram has this as a little button, not hidden away in a drawer. I think that should be the case here too. Especially once you combine RedPhone and TextSecure.

@mawed
Copy link

mawed commented Jul 20, 2015

Sorry for the offtopic question (I do not know where to ask elsewhere, in #520 I can't write anything):
Was there some commit and update, when closing #520 with milestone 2.22.0?
Or was the toDo List just seperated in Audio and video issue?
I thought (hoped) this may would include the new media branch.

@McLoo
Copy link
Contributor

McLoo commented Jul 20, 2015

@mawed Direct capture is in beta right now
and:
520 was

Closed in favor of # 3563 and # 3564 since all these different types of media captures will be separate PRs, making it easier to track progress.

@Dyras
Copy link

Dyras commented Jul 20, 2015

Is direct capture in the latest beta? If so, I don't see it.

@mawed
Copy link

mawed commented Jul 20, 2015

Thank you for the information
so it was just divided not finished with milestone 2.22.0.

That's what I thought after the update with no (visible) changes.

@heyimgay
Copy link
Contributor

heyimgay commented Aug 6, 2015

It would be cool if the audio was encoded in opus so we can have awesome quality at a small size:

Opus is a totally open, royalty-free, highly versatile audio codec. Opus is unmatched for interactive speech and music transmission over the Internet, but is also intended for storage and streaming applications. It is standardized by the Internet Engineering Task Force (IETF) as RFC 6716 which incorporated technology from Skype's SILK codec and Xiph.Org's CELT codec.

ffmpeg has a codec for it so we can use https://github.com/guardianproject/android-ffmpeg for example

@amenk
Copy link

amenk commented Nov 20, 2015

👍

@mawed
Copy link

mawed commented Nov 27, 2015

I'm on 3.5.2 (beta) and I had this feature last version (or the one before). Was it taken back because of problems?

@mcginty
Copy link
Contributor Author

mcginty commented Nov 27, 2015

@mawed yep

@mcginty mcginty reopened this Nov 27, 2015
@mawed
Copy link

mawed commented Nov 27, 2015

@mcginty Ok thanks for reopening.
I liked the look and feel of it (just to mention ;-)).

Edit: Milestone 3.5.0 should be also deleted or?

@heyimgay
Copy link
Contributor

@mcginty any chance we'll get opus audio messages next time around?

@smichel17
Copy link

If there's a better place to give feedback on this or other issues, let me know.

When I used the direct audio capture feature for the time it was enabled, I liked hold to record, but found it jarring that it would immediately send upon letting go. I expected it to act like direct image capture: when I let go, it attaches the audio clip, which I now have a chance to review before sending.

@ghost
Copy link

ghost commented Feb 4, 2016

i am intentionally spamming and wasting the developers' time

@smichel17
Copy link

Signal Android Beta had direct audio capture as well. It was removed because it crashed Signal iOS. I imagine when OWS finds a full time iOS dev they will quickly reinstate the feature.


From: cxarmonato [notifications@github.com]
Sent: Thursday, February 04, 2016 12:41
To: WhisperSystems/Signal-Android
Cc: Michel, Stephen J.
Subject: Re: [Signal-Android] Direct audio capture (#3563)

implemented here: https://play.google.com/store/apps/details?id=org.privatechats.securesms


Reply to this email directly or view it on GitHubhttps://github.com//issues/3563#issuecomment-179961633.

@agrajaghh
Copy link
Contributor

@Tormen Please don't bump issues (they just create extra email notifications for the devs). Thanks

https://github.com/WhisperSystems/Signal-Android/blob/master/CONTRIBUTING.md#dont-bump-issues

@Tormen
Copy link

Tormen commented Apr 13, 2016

Is there anything I can do to help ?

According to the link you sent me this question should be fine, no ? --- I really don't want to be stuborn here, but just transmit my sincere wish to help!!

If you don't like people to offer their help, could you please update your dont-bump-issues to also list "offer your help" in the list of unwanted annoyances:

Thus bumping issues with 👍s, me toos or asking for updates just generate unnecessary email

@agrajaghh
Copy link
Contributor

Is there anything I can do to help ?

#3563 (comment):

It was removed because it crashed Signal iOS. I imagine when OWS finds a full time iOS dev they will quickly reinstate the feature.

afaik this is still true, so I don't think there is anything to do at the moment until there is full time iOS dev again...

@signalapp signalapp locked and limited conversation to collaborators Apr 13, 2016
@2-4601 2-4601 closed this as completed Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.