Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts are incorrectly shown to be reachable via Signal Video #1861

Closed
1 task done
kiliankoe opened this issue Mar 18, 2017 · 5 comments
Closed
1 task done

Contacts are incorrectly shown to be reachable via Signal Video #1861

kiliankoe opened this issue Mar 18, 2017 · 5 comments

Comments

@kiliankoe
Copy link

  • I have searched open and closed issues for duplicates

Bug description

Every contact on my phone without other means of video contact is shown to be reachable via Signal on the contact sheet. On tapping this button, Signal shows an error that this contact is not a Signal user.

I have enabled iOS Call Integration and Show Caller's Name & Number in Signal, which I believe might be relevant in this case? Although it also doesn't make a difference for this issue if I disable them.

Screenshots

img_6032

img_6033

Device info

Device: iPhone 6s
iOS version: 10.2.1 (14D27)
Signal version: 2.8.2

@michaelkirk
Copy link
Contributor

Hi @kiliankoe,

I agree that this is confusing, but I don't think we can fix it.

If you have any other calling apps installed, you can long press on the video button to see those other apps listed - regardless of if the user actually has an account with that app. This is just how the contacts app works. There's no way for us to say "tell contacts app that this user is or is not a Signal user".

If you do call this user using a different app (e.g.) LINE, the Contacts app will assume that it's your preferred contact method for that user, and will surface (e.g.) LINE for the top video option instead of Signal.

@NicolasCGN
Copy link

You could give the option to send an invitation in that dialogue to install Signal. Google Duo does it

@kiliankoe
Copy link
Author

kiliankoe commented Mar 22, 2017

@michaelkirk Hmm, thanks for the comment. That's unfortunate. I'm going to look through the CallKit APIs for some context and then open a radar about that. I don't see why iOS should basically be lying to the user about their contacts being reachable where they're not.

@NicolasCGN
Copy link

From the Contacts app, you can also place Whatsapp and Duo calls to contacts that are not registered.

Interestingly enough, the Contacts app does know which contacts you can text through Whatsapp and which ones not (not registered).

It would be also nice to have the option of placing Signal messages through the Contacts app.

@michaelkirk
Copy link
Contributor

michaelkirk commented Mar 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants