Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush logs before submitting logs. #1763

Merged
merged 1 commit into from Feb 14, 2017
Merged

Flush logs before submitting logs. #1763

merged 1 commit into from Feb 14, 2017

Conversation

charlesmchen
Copy link
Contributor

I've verified that very recent activity shows up in submitted logs after this change.

PTAL @michaelkirk

michaelkirk
michaelkirk approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesmchen
Copy link
Contributor Author

@michaelkirk I just pushed another commit. PTAL

@charlesmchen charlesmchen force-pushed the charlesmchen/flushLogsVsSubmitLogs branch 2 times, most recently from c3bea80 to dde8132 Compare February 14, 2017 18:53
@charlesmchen charlesmchen merged commit dde8132 into master Feb 14, 2017
@charlesmchen charlesmchen mentioned this pull request Feb 14, 2017
Merged
@charlesmchen
Copy link
Contributor Author

@michaelkirk I've moved the follow-on changes to a separate PR: #1764

@charlesmchen charlesmchen deleted the charlesmchen/flushLogsVsSubmitLogs branch February 14, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkirk michaelkirk michaelkirk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlesmchen @michaelkirk