This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Update SignalRecipient with “is WebRTC enabled” property from service. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
suggested changes
Jan 13, 2017
| [[SignalRecipient alloc] initWithTextSecureIdentifier:contactId | ||
| relay:relay | ||
| supportsVoice:YES | ||
| // Default to NO; ContactsUpdater will try to update this property. |
There was a problem hiding this comment.
If the contactsUpdater does create a SignalRecipient with the correct supportsWebRTC value, aren't we clobbering it with a NO on line 48? [recipient saveWithTransaction:transaction];
Maybe the save needs to be moved up. Or maybe it can be deleted, since it looks like ContactsUpdater saves the recipient.
There was a problem hiding this comment.
Great catch. Fixed, and added a comment.
Also, per our offline conversation, let's keep thinking about how we can:
- Avoid using concurrency unless necessary.
- Avoid concurrency issues when mutating our models.
There was a problem hiding this comment.
Agree.
Some relevant reading that might shape our solutions https://github.com/YapStudios/YapDatabase/wiki#intermediate
charlesmchen
force-pushed
the
charlesmchen/webrtcSetting2
branch
from
ccec56a
to
08ba42c
Compare
// FREEBIE
|
PTAL @michaelkirk |
|
LGTM 🌯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @michaelkirk