Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnails not rendering #3051

Closed
moxie0 opened this issue Apr 23, 2015 · 7 comments
Closed

Thumbnails not rendering #3051

moxie0 opened this issue Apr 23, 2015 · 7 comments
Assignees
@mcginty
Milestone
2.13.0

Comments

@moxie0
Copy link
Contributor

moxie0 commented Apr 23, 2015

Built a RC and tried sending a few images. This happens every so often, where the entire message bubble (except for the arrow) fails to render:

glide-sucks
@moxie0 moxie0 added this to the 2.13.0 milestone Apr 23, 2015
@moxie0 moxie0 added the bug label Apr 23, 2015
@moxie0
Copy link
Contributor Author

moxie0 commented Apr 23, 2015

(scroll performance is also pretty degraded on GB)

@mcginty
Copy link
Contributor

mcginty commented Apr 24, 2015

still haven't reproduced, both on my device and emulator

@mcginty
Copy link
Contributor

mcginty commented Apr 24, 2015

YES REPRODUCED FINALLY

@mcginty
Copy link
Contributor

mcginty commented Apr 24, 2015

ok will work this out

@mcginty
Copy link
Contributor

mcginty commented Apr 24, 2015

If you experience this then scroll up and back down, it fixes itself which makes me think this is a race case with the thumbnail generation.

@mcginty
Copy link
Contributor

mcginty commented Apr 24, 2015

ok got it. if the image isn't loaded into the thumbnail view before you hit send, this will happen.

@mcginty
Copy link
Contributor

mcginty commented Apr 24, 2015

so it's caused by quickly adding an image and immediately tapping send.

mcginty added a commit to mcginty/TextSecure that referenced this issue Apr 25, 2015
@mcginty
fix race conditions around sending attachments.
8dccbd2 
Fixes signalapp#3051
// FREEBIE
@mcginty mcginty mentioned this issue Apr 25, 2015
Merged
pR0Ps pushed a commit to SilenceIM/Silence that referenced this issue May 1, 2015
@mcginty @pR0Ps
make part and mms insertion a single transaction
28bb340 
Fixes signalapp/Signal-Android#3051
Closes signalapp/Signal-Android#3059
// FREEBIE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcginty mcginty

Labels
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@mcginty @moxie0