Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 'add contact info' option on the conversation contextual menu #381

Merged
merged 1 commit into from Oct 20, 2013

Conversation

meskio
Copy link
Contributor

@meskio meskio commented Oct 17, 2013

This option is used to add phone numbers from the contact list on the
messages.

For #211

This option is used to add phone numbers from the contact list on the
messages.
@meskio
Copy link
Contributor Author

meskio commented Oct 17, 2013

I want to add also support for email, im, ... but that will come another day.

@moxie0
Copy link
Contributor

moxie0 commented Oct 17, 2013

Are you aware that it's possible to tap on the avatar icon in order to open up a quick contact badge? Do you want this in addition to that?

@meskio
Copy link
Contributor Author

meskio commented Oct 17, 2013

The idea of this patch is to append a phone number from the contact list to the text message that you are writing. It tries to implement the same functionality that 'Insert contact info' does on the default sms app on android.

I don't see how to do this with the current version, but I may be missing something.

@moxie0
Copy link
Contributor

moxie0 commented Oct 17, 2013

Oh I see!

Does the UI end up working to your satisfaction? If you have an existing thread, and then add a recipient, that will allocate a new thread. But the display probably won't update until you go back to the ConversationList and return to the new ConversationActivity?

My default messaging app doesn't have that option. How does its UI on your system deal with the change?

@meskio
Copy link
Contributor Author

meskio commented Oct 17, 2013

I'm not sure if I understand what you are saying. I don't add recipients to the conversation, I just add the phone number as text on the message body. So is a way to send the contat information to the existing recipients of the conversation.

The UI works as good as the CyanogenMod sms app. There is one thing I don't like much, if you are writing a message, so you have the keyboard displayed, after adding the contact the keyboard hides itself. But that also happens on the CyanogenMod app.

Also the contact is always added to the end of the written text, it may make more sense to add it to wherever is the cursor.

@moxie0
Copy link
Contributor

moxie0 commented Oct 17, 2013

Hah, ok, I get it now.

moxie0 added a commit that referenced this pull request Oct 20, 2013
New 'add contact info' option on the conversation contextual menu
@moxie0 moxie0 merged commit 891e3ae into signalapp:master Oct 20, 2013
@meskio meskio deleted the add_contact branch October 21, 2013 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants