Move activities dressed as dialogs into actual dialogs #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls have a look at #2821. I combined |
| descriptionText.setMovementMethod(LinkMovementMethod.getInstance()); | ||
| } | ||
|
|
||
| private static IncomingPreKeyBundleMessage getMessage(MessageRecord messageRecord) |
There was a problem hiding this comment.
it's necessary since it's used in the constructor while passing a result into super. (this is the case for all of those statics, so applies to the other comments)
mcginty
force-pushed
the
feature/faux-dialog-activities
branch
2 times, most recently
from
0ec3789
to
414cb90
Compare
// FREEBIE
mcginty
force-pushed
the
feature/faux-dialog-activities
branch
from
414cb90
to
c83f5e5
Compare
|
updated |
pR0Ps
pushed a commit
to SilenceIM/Silence
that referenced
this pull request
May 25, 2015
Closes signalapp/Signal-Android#3158 // FREEBIE
pR0Ps
pushed a commit
to SilenceIM/Silence
that referenced
this pull request
May 26, 2015
Closes signalapp/Signal-Android#3158 // FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.