Support for static RecipientDetails for certain shortcodes. #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,7 +151,8 @@ public RecipientDetails call() throws Exception { | |||
| cursor.close(); | |||
| } | |||
|
|
|||
| return new RecipientDetails(null, number, null, ContactPhotoFactory.getDefaultContactPhoto(null), color); | |||
| if (STATIC_DETAILS.containsKey(number)) return STATIC_DETAILS.get(number); | |||
There was a problem hiding this comment.
i feel like the user contact db should override whatever we hardcode
There was a problem hiding this comment.
ah i misread, this is just what it fills in before resolving in the contacts db.
yeah this lgtm
|
in 2.24.0 |
BLeQuerrec
pushed a commit
to SilenceIM/Silence
that referenced
this pull request
Jul 31, 2015
Closes signalapp/Signal-Android#3813 // FREEBIE Upstream commit: signalapp/Signal-Android@bbf33f8 Don't use Amazon asset; replaced by the default one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// FREEBIE