Listen for recipient changes in conversations and group updates. #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| long id = cursor.getLong(cursor.getColumnIndexOrThrow(SmsDatabase.ID)); | ||
| String type = cursor.getString(cursor.getColumnIndexOrThrow(MmsSmsDatabase.TRANSPORT)); | ||
| MessageRecord messageRecord = getMessageRecord(id, cursor, type); | ||
|
|
||
| item.set(masterSecret, messageRecord, locale, batchSelected, selectionClickListener, | ||
| groupThread, pushDestination); | ||
| if (view instanceof ConversationItem) { |
There was a problem hiding this comment.
why not use getItemViewType() to determine the view type?
|
updated |
BLeQuerrec
pushed a commit
to SilenceIM/Silence
that referenced
this pull request
Sep 21, 2015
Closes signalapp/Signal-Android#4079 // FREEBIE Upstream commit: signalapp/Signal-Android@0794380
BLeQuerrec
pushed a commit
to SilenceIM/Silence
that referenced
this pull request
Oct 1, 2015
Closes signalapp/Signal-Android#4079 // FREEBIE Upstream commit: signalapp/Signal-Android@0794380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks out conversation "updates" (currently just group change info) into a separate list item class. From there we'll be able to add other things (security indicators, call records, etc...).
It also resolves recipient contact info in the group update messages, and should fix the bug where recipient info sometimes doesn't resolve in conversations.