Support for in-app audio playback. #4270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more SlideDeck futures, just SlideDecks. // FREEBIE
| if (cbSkip > 0) {// It is a seek or skip request if there's a Range | ||
| // header | ||
| headers += "HTTP/1.1 206 Partial Content\r\n"; | ||
| headers += "Content-Type: " + attachment.getContentType() + "\r\n"; |
There was a problem hiding this comment.
do we need to sanitize/escape attachment.getContentType()?
There was a problem hiding this comment.
in what way? it's a mime type right?
There was a problem hiding this comment.
it's a string passed in via protobuf from the network that we assume is a validly constructed MIME, no?
Allows for contrast coloring of audio controls, for one thing. // FREEBIE
// FREEBIE
// FREEBIE
|
in 3.1.0 |
BLeQuerrec
pushed a commit
to SilenceIM/Silence
that referenced
this pull request
Nov 29, 2015
Closes signalapp/Signal-Android#4270 // FREEBIE Upstream commit: signalapp/Signal-Android@15c6f18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.