Support for archive actions

[moxie0]

// FREEBIE

[mcginty]

last I checked there were lots of bugs in this FAB implementation across platforms, which versions did you test this on?

[moxie0]

works on GB, not with the coordinatorlayout stuff, but neither does the 3rd party

[2-4601]

Tested on Huawei U8800, Android 4.0.4.
Looks like you can archive the Archived conversations (n) item itself and then Signal will crash:

E/AndroidRuntime(21254): FATAL EXCEPTION: main
E/AndroidRuntime(21254): java.lang.ClassCastException: org.thoughtcrime.securesms.ConversationListItemAction cannot be cast to org.thoughtcrime.securesms.ConversationListItem
E/AndroidRuntime(21254):    at org.thoughtcrime.securesms.ConversationListFragment$ArchiveListenerCallback.onSwiped(ConversationListFragment.java:380)
E/AndroidRuntime(21254):    at android.support.v7.widget.helper.ItemTouchHelper$4.run(ItemTouchHelper.java:669)
E/AndroidRuntime(21254):    at android.os.Handler.handleCallback(Handler.java:605)
E/AndroidRuntime(21254):    at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime(21254):    at android.os.Looper.loop(Looper.java:137)
E/AndroidRuntime(21254):    at android.app.ActivityThread.main(ActivityThread.java:4424)
E/AndroidRuntime(21254):    at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(21254):    at java.lang.reflect.Method.invoke(Method.java:511)
E/AndroidRuntime(21254):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:787)
E/AndroidRuntime(21254):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:554)
E/AndroidRuntime(21254):    at dalvik.system.NativeStart.main(Native Method)
W/ActivityManager(  292):   Force finishing activity org.thoughtcrime.securesms/.RoutingActivity

[moxie0]

lol good one

[moxie0]

updated

[mcginty]

short is super short, especially the first time

[mcginty]

Another thing Inbox does which makes sense is once you unarchive the last item, the archive should close and bring you back to the inbox.

[mcginty]

Batch-selecting archived conversations and choosing unarchive says "Archived conversations" in the Snackbar

[mcginty]

If there's a "delete conversation" menu item within the conversation overflow menu, is it strange not to be able to archive/unarchive from within a conversation as well?

[mcginty]

Swiping to archive conversations in fast-ish succession sometimes ends up with a snackbar not being displayed for the final swipe.

[moxie0]

@mcginty thoughts on removing "delete conversation" from the menu conversation activity overflow menu?

[mcginty]

sounds good to me.

[moxie0]

updated

[2-4601]

When I archived my first conversation by swiping it to the right and then went to the archive list to see where it went my first intuition was to unarchive the conversation by swiping it back to the left. That's because visually the main conversation list is on the left and the archive list is on the right. But currently both archive and unarchive are swipe to to the right gestures.

It just feels more real if you can toss them left and right.

But if another swipe action (such as delete) is introduced later then I guess the above doesn't make sense any more.

[moxie0]

@2-4601 Yeah that's my concern.