Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [War module] Incorrect Town is marked as War winner #379

Closed
farum12 opened this issue Dec 4, 2023 · 3 comments
Closed

[Bug] [War module] Incorrect Town is marked as War winner #379

farum12 opened this issue Dec 4, 2023 · 3 comments
Labels
type: bug This issue is about something that isn't working as intended

Comments

@farum12
Copy link

farum12 commented Dec 4, 2023

It has been observed that Player is able to win war simply by teleporting to spawn via /spawn command (Essentials).

It has been observed that incorrect Town is marked as War winner - "losers" are marked as winners and they obtain the prize.

Prerequisites:

  • Player Farum
  • Player Farum is mayor of Farumowo town
  • Player Testur
  • Player Testur is mayor of Testuchowo town
  • Farumowo & Testuchowo both have 5000 in town coffers (the amount to start a war)
  • Farumowo & Testuchowo are sworn enemies by their relations

Repro Steps:

  1. (as Farum) Use /town war declare Testuchowo command.
  2. (as Testur) Accept war declaration via clicking chat message.
  3. -wait until both players are teleported to initial positions-
    4. (as Testur) Use /spawn command.
  4. (as Farum) Kill Testur using sword.
    5. Observe as HuskTowns detects that Testur has run away from the battlefield - the message is visible on both Players' chats.
  5. Observe as HuskTowns detects that Testur has been killed in the battle.
  6. Observe the issue, as HuskTowns declares that Testuchowo is a winner.

Expected Results:
Town, which Users were not removed from the battle should be considered as winners.
Town, which Users were not killed in the battle (or left the battle) should be considered as winners.
In the following example - Farumowo.

Actual Results:
Town, which Users were removed from the battle were considered as winners.
Town, which Users were killed in the battle (or left the battle) are considered as winners.
In the following example - Testuchowo.

Picture 1
Testur was removed from the battle operations. (correct)
Testuchowo won the war against Farumowo! (incorrect)

2023-12-04_19 53 01

@farum12
Copy link
Author

farum12 commented Dec 4, 2023

Please note that I wasn't able to investigate the issue further due to War module limitations - we're running (and testing on prod), so I wasn't eager to set it below 0. There could be a command to reset cooldown, like /admintown war resetcooldown :)

@farum12
Copy link
Author

farum12 commented Dec 5, 2023

Further investigations from my players:

It seems that the teleportation itself is not a root cause.
Prerequisities:

  • Player BookLover
  • Player BookLover is mayor of Librarium
  • Player Piwoo746
  • Player Piwoo746 is mayor of Stalgard

BookLover was killed by Piwoo746.
Librarium has won the war against Stalgard.

image12345

@farum12 farum12 changed the title [Bug] [War module] Town is able to win a War by using /spawn command [Bug] [War module] Incorrect Town is marked as War winner Dec 5, 2023
@farum12
Copy link
Author

farum12 commented Dec 5, 2023

I updated the bug - certainly, the winners are marked incorrectly. It doesn't matter if user left the battle or was killed.

@WiIIiam278 WiIIiam278 added the type: bug This issue is about something that isn't working as intended label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug This issue is about something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants