Update to 1.29

[Seb35]

It doesn’t work with MediaWiki 1.29 + VisualEditor branch REL1_29 + PageForms tag 4.1.2. I began working on the update and I propose to dedicate the following issue to this task. I guess there will be many issues to be solved one by one.

[Seb35]

In a first step, the JS console says "Error: Unknown dependency: ext.visualEditor.standalone". After some digging this resource was present in VisualEditor REL1_28 but is absent is REL1_29, specifically it was deleted in 1d7f929, with the comment that it was used in Flow but no more used. In Flow it seems this resource "ext.visualEditor.standalone" is only a "package" used to embed specific scripts, which are probably now in other resources.

In Flow this resource was added in REL1_25 and removed in REL1_28. In the meantime it was only called in the file "modules/editor/editors/visualeditor/mw.flow.ve.Target.js", removed in 838d204 with the comment it was then part of VE core since 363c804. I am still digging, searching how Flow replaced ve.init.sa in recent versions.

[Seb35]

In Flow I tracked ve.init.sa and found it was removed in 8088e888. I tried a similar change in VEForPageForm, modifying "ve.init.sa.Target" to "ve.init.mw.Target"; then the VE started to load and failed with "TypeError: this.getSurface(...) is null". Next step…

[pierreboutet]

Hi,
we are currently integrating this extension into the pageform extension, for mw 1.29, you should use the PageForm available here : https://github.com/Wikifab/PageForms , using branch veforpageforms

here is a direct link : https://github.com/Wikifab/PageForms/archive/veforpageforms.zip
It is the latest version of PageForm, which integrate veforpageforms and tested on MW 1.29

Yaron Koren want to merge it into the original PageForm extension, but it is not done yet.

[Seb35]

Thanks, I tried this way and didn’t succeed for now; I will continue trying and studying VE in more details.

[kghbln]

Out of curiosity. Is there any progress on integrating this extension into Page Forms?

[pierreboutet]

Hello,
I am still using and updating the forked PageForm (available here https://github.com/Wikifab/PageForms ) where this extension is integrated into.

As of today, there is not progress about merging it in the original PageForm extension.

[kghbln]

Thanks a lot for your information!