Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Copied code from my steps extension #4

Closed
aramvisser opened this issue Aug 26, 2017 · 2 comments
Closed

Copied code from my steps extension #4

aramvisser opened this issue Aug 26, 2017 · 2 comments

Comments

@aramvisser
Copy link

Hi @Wikiki,

There are some issues with your steps extension code. I noticed that you changed the look for your steps extension since I made my extension. It now more closely resembles mine.

I can also clearly tell you directly copied some code from me. Your steps-size sass mixin is very similar with the exact same comment above it.

Your steps examples in the documentation are also taken directly from me (you only use 4 steps, but your final step still says step 5).

You also added very similar css classes that I used, like step-marker and step-content.

Can you either rewrite all those parts to be your own or give me credit to say where you got it from?

@Wikiki
Copy link
Owner

Wikiki commented Aug 26, 2017

Hi @aramvisser,

You're right, I took your example text for my documentation -> It as been changed now.

I also renamed my selector from 'tag' to 'marker' because I found your choose for the name is more relevant that my old one: I'll give you credit for that.

I also took your mixin declaration you're right but not the idea and not the way to implement it (only the declaration).

I've added a credit to you on my documentation page and in the README.

Kindly regards,

@Wikiki Wikiki closed this as completed Aug 26, 2017
@aramvisser
Copy link
Author

Thanks for the credit.

Good luck with the rest of your extensions and the documentation!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants