Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display bulk import file name as uploaded #372

Open
TanyaStere42 opened this issue Feb 16, 2024 · 6 comments
Open

display bulk import file name as uploaded #372

TanyaStere42 opened this issue Feb 16, 2024 · 6 comments
Labels
bug something's broken!

Comments

@TanyaStere42
Copy link
Member

TanyaStere42 commented Feb 16, 2024

Context
Wildbook currently does filename processing to remove characters from bulk import file names

To allow for easy reconciliation between files in system and external to the system, we need to display the filename as it was originally uploaded, regardless of what preprocessing we do. This means that the original filename should be stored as a string and used for display.
(update to parameters json for ImportTask)

Current Behavior
file Caitlin_December_final.xlsx displays as CaitlinDecemberfinal.xlsx

Expected Behavior
file Caitlin_December_final.xlsx displays as Caitlin_December_final.xlsx

Acceptance Criteria
Display is updated on the following pages to show the original file name:

  • /src/main/java/org/ecocean/servlet/importer/StandardImport.java
  • /src/main/webapp/imports.jsp
  • /src/main/webapp/import.jsp

Notes
Related to #267

Community link
https://community.wildme.org/t/underscores-dashes-no-longer-displaying-or-exporting-correctly/2721

@TanyaStere42 TanyaStere42 added the bug something's broken! label Feb 16, 2024
@TanyaStere42
Copy link
Member Author

@TanyaStere42 TanyaStere42 added help wanted highest priority good first issue small, contained tasks that can be done with minimal onboarding labels Feb 16, 2024
@T4Cmaureen
Copy link

I'd just like to clarify that we also need the original image file name to display accurately on the match results page where it is currently displayed over top of the annotated target image and the annotated match candidate(s). Same criteria as above for exports:
Current Behavior
file Caitlin_December_final.xlsx currently displays as CaitlinDecemberfinal.xlsx

Expected Behavior
file Caitlin_December_final.xlsx currently displays as Caitlin_December_final.xlsx

Per this post on the Community forum: https://community.wildme.org/t/underscores-dashes-no-longer-displaying-or-exporting-correctly/2721?u=acwadmin1

@TanyaStere42
Copy link
Member Author

Excellent! Thank you for catching that, I'll get the requirement updated to include that

@genzarchitect
Copy link

@TanyaStere42 I would like to give a try could you please assign it to me

@TanyaStere42
Copy link
Member Author

Absolutely! If you find you need help with system setup or anything, checkout the discord (although we are heading into a long weekend)

@T4Cmaureen

This comment was marked as off-topic.

@TanyaStere42 TanyaStere42 removed help wanted highest priority good first issue small, contained tasks that can be done with minimal onboarding labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something's broken!
Projects
None yet
Development

No branches or pull requests

3 participants