Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShephardProperties does not always load properties from the correct path #504

Open
doinkythederp opened this issue Apr 30, 2024 · 2 comments · Fixed by #505
Open

ShephardProperties does not always load properties from the correct path #504

doinkythederp opened this issue Apr 30, 2024 · 2 comments · Fixed by #505
Labels
project_support devops, build changes, etc etc

Comments

@doinkythederp
Copy link
Contributor

ShephardProperties is passed relative paths when loading properties, which are read relative to the current working directory. This is often the Tomcat install (System.getProperty("catalina.home")), but this is not always true (e.g. when running Tomcat manually or when using the Homebrew service). Thus, properties will sometimes fail to load.

@TanyaStere42
Copy link
Member

#505 proved to be a breaking change. issues need to be resolved for this to be considered complete

@TanyaStere42 TanyaStere42 reopened this May 7, 2024
@TanyaStere42
Copy link
Member

We could not load Properties files on an Ubuntu 18.04 machine, causing Wildbook to fail to start and throw messages such as:

++ StartupWildbook.skipInit() test on null [/tmp/WB_SKIP_INIT] --> false
2024-05-07T23:05:21.760Z WildbookIAM init() called on context context0
2024-05-07T23:05:21.760Z WildbookIAM init() called on context context0
2024-05-07T23:05:21.765Z ####### TestPlugin ####### org.ecocean.ia.plugin.TestPlugin@72120ec7[TestPlugin] init() called on context context0
Super weird case met in ShepherdProperties.getProps(IA.properties, , null, null). Returning generated default props.
IA.getProperty(enableTestPlugin) has no properties; IA.properties unavailable?
2024-05-07T23:05:21.772Z ####### TestPlugin ####### org.ecocean.ia.plugin.TestPlugin@72120ec7[TestPlugin] init() called on context context0
INFO: IAPluginManager.startup() called
Super weird case met in ShepherdProperties.getProps(IA.properties, , context0, null). Returning generated default props.
IA.getProperty(IBEISIADisableIdentification) has no properties; IA.properties unavailable?
++ StartupWildbook.skipInit() test on PRIMEIA [/tmp/WB_SKIP_INIT_PRIMEIA] --> false
2024-05-07T23:05:21.772Z INFO: WildbookIAM.prime(context0) called - NOTE this is deprecated and does nothing now.
 ???? setting iaPrimed to true
Super weird case met in ShepherdProperties.getProps(commonConfiguration.properties, , context0, null). Returning generated default props.
Super weird case met in ShepherdProperties.getProps(commonConfiguration.properties, , context0, null). Returning generated default props.
07-May-2024 23:05:21.778 SEVERE [localhost-startStop-1] org.apache.catalina.core.StandardContext.startInternal One or more listeners failed to start. Full details will be found in the appropriate container log file
07-May-2024 23:05:21.782 SEVERE [localhost-startStop-1] org.apache.catalina.core.StandardContext.startInternal Context [] startup failed due to previous errors
* StartupWildbook destroyed called for: Wildbook® [ via /var/lib/tomcat8/webapps/wildbook/]```

@TanyaStere42 TanyaStere42 removed this from the 10.2.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project_support devops, build changes, etc etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants