Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export fixes #964

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Export fixes #964

merged 4 commits into from
Feb 2, 2024

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Feb 1, 2024

some fixes:

  • allow admin users to have access to search/export even when not also researchers
  • fix a bug still using the deprecated EXPORT permission
  • increase number of records allowed to be exported
  • test fix

Copy link

@erinz2020 erinz2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5cfb106) 73.3% compared to head (7bc9e50) 73.4%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #964     +/-   ##
=======================================
+ Coverage   73.3%   73.4%   +0.1%     
=======================================
  Files        238     242      +4     
  Lines      23716   24023    +307     
  Branches    4336    4396     +60     
=======================================
+ Hits       17392   17654    +262     
- Misses      5043    5063     +20     
- Partials    1281    1306     +25     
Files Coverage Δ
app/extensions/__init__.py 77.8% <100.0%> (ø)
app/modules/encounters/resources.py 79.8% <100.0%> (ø)
app/modules/sightings/resources.py 77.3% <100.0%> (ø)
app/modules/users/permissions/rules.py 82.9% <ø> (-0.9%) ⬇️
app/modules/individuals/resources.py 74.7% <0.0%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae46c0a...7bc9e50. Read the comment docs.

@naknomum naknomum marked this pull request as ready for review February 1, 2024 23:37
@TanyaStere42 TanyaStere42 added this to the Codex Release 2.2 milestone Feb 2, 2024
@TanyaStere42 TanyaStere42 merged commit a9b8ee6 into main Feb 2, 2024
10 of 11 checks passed
@TanyaStere42 TanyaStere42 deleted the export_fixes branch February 2, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants