Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.from() is not a function #92

Closed
lardawge opened this issue Aug 28, 2015 · 5 comments
Closed

Array.from() is not a function #92

lardawge opened this issue Aug 28, 2015 · 5 comments

Comments

@lardawge
Copy link

I am returning a record from the api after image upload... because I am not returning an array, EmberDroplet is trying to create one. In Chrome, and I am sure many other browsers at this point, Array.from() does not exist... Any suggestion as to what to do here?

@lardawge
Copy link
Author

Ended up loading the shim to support Array.from(). Seems very heavy handed for a lib to require this for one line of code but OK.

@Wildhoney
Copy link
Owner

Sorry @lardawge I forgot to respond to this issue. Agreed its overkill, and I thought I'd added a check for Array.from before using it. Will look into it tomorrow and push a fix.

@Wildhoney Wildhoney reopened this Aug 31, 2015
@lardawge
Copy link
Author

Thanks @Wildhoney

I am looking into another issue that I am trying to solve related to hooks being overwritten. I believe it is an issue that effects options as well... will open an PR if I can get my head around it.

@Wildhoney
Copy link
Owner

Options issue is likely to be related to the following issue: #91 which is another priority fix 👍

I've just pushed the change for Array.from as v1.0.1 so please verify and close this issue if it's fixed – I'm going to surmise you — for some reason — have Array.from defined, but it's not the native in-built function but a string or some other data type, which is why the validation was failing.

If the options issue you're investigating is related to #91 then please continue discussion there, otherwise open another ticket.

Thanks @lardawge ! And sorry for forgetting to update this ticket before.

@Wildhoney Wildhoney reopened this Aug 31, 2015
@lardawge
Copy link
Author

Yes, fixed. Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants