issue #629 followup: instruction on cargo build and install usage #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaleh
requested changes
Feb 7, 2018
INSTALL
Outdated
| @@ -33,6 +33,11 @@ some of the steps manually. The more detailed description in the other | |||
| sections of this guide will help you do that, so please refer to those | |||
| sections if you need to. | |||
|
|
|||
| 0. Before you start: Remacs uses cargo for it's build process. if | |||
There was a problem hiding this comment.
It's is a conjunction. You want its.
INSTALL
Outdated
| you build as an unpriviledged user and then install as an | ||
| administrator cargo will rebuild remacs. Make sure you have the | ||
| right nightly version installed for both users. | ||
|
|
There was a problem hiding this comment.
Maybe mention rust-toolchain as the source of that version?
There was a problem hiding this comment.
hm, not sure how elaborate to be here,
should i just mention rustc or refer it?
There was a problem hiding this comment.
How about
"Make sure you have the right nightly version as found in the rust-toolchain file."
Or something like that.
shaleh
pushed a commit
to shaleh/remacs
that referenced
this pull request
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shaleh I found only refs to this in the INSTALL file so no changes in readme