Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision resolving breaking if too many collisions shared #353

Closed
cpaniaguam opened this issue Nov 13, 2023 · 3 comments
Closed

Collision resolving breaking if too many collisions shared #353

cpaniaguam opened this issue Nov 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@cpaniaguam
Copy link
Member

function resolvecollisions!(matched_pairs)

When floes share several potential matching floes, the collision resolution routine drops rows that later are looked up by row index which throws an out of bounds error when checking goodness of fit for floes having dropped floes in its set of potential matches.

@cpaniaguam cpaniaguam added the bug Something isn't working label Nov 13, 2023
@cpaniaguam cpaniaguam added this to To do in Ice Floe Coding Tasks via automation Nov 13, 2023
@cpaniaguam cpaniaguam self-assigned this Nov 13, 2023
@tdivoll
Copy link
Collaborator

tdivoll commented Nov 15, 2023

Can you create a unique ID based on index and floe ID and then do the lookup using the unique ID, but still drop rows by only index when needed?

@cpaniaguam
Copy link
Member Author

I like that idea. A function could be created to drop by floe ID in a safer way than by row index.

@mirestrepo
Copy link
Collaborator

This problem went away when switching to initial floe pairing method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants