Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting in place of a selection #6

Open
gasparl opened this issue Jan 22, 2023 · 2 comments
Open

Inserting in place of a selection #6

gasparl opened this issue Jan 22, 2023 · 2 comments

Comments

@gasparl
Copy link
Collaborator

gasparl commented Jan 22, 2023

In your current implementation, insertions can only be done if the cursor is placed somewhere in the document and nothing is selected. This is fine by me, but, FYI, I wrote a custom function that should work with selections too. I can't guarantee it's 100% bug-free, but still the option is there.

@WillemSleegers
Copy link
Owner

Yeah seems like a good option. Can you get rid of the commented out code and add a little bit more commenting about how it works? Like what the elements are and why they're there and why you need to loop over them.

@WillemSleegers
Copy link
Owner

And then make a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants