Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final pull request go PRRRRR (#40, #56, #64): Project/code cleanup and refactor + skin system #63

Merged
merged 11 commits into from Apr 24, 2022
Merged

Final pull request go PRRRRR (#40, #56, #64): Project/code cleanup and refactor + skin system #63

merged 11 commits into from Apr 24, 2022

Conversation

Shirajuki
Copy link
Collaborator

@Shirajuki Shirajuki commented Apr 22, 2022 •
edited

This PR fixes the issue #40, #56 and #64 by refactoring the whole project as well as adding a skin system for changing user ufo skins.

The code refactoring includes:

  • Minor bugfixes (including Loose two hearts #56)
  • Removes unnecessary logging
  • Removes dead / unused code
  • Removes unused imports
  • Removes unnecessary imports in build scripts
  • Removes unnecessary subprojects (ios & desktop)
  • General code refactoring of "dirty codes"

closes #40
closes #64
closes #56

@Shirajuki Shirajuki self-assigned this Apr 22, 2022
@Shirajuki Shirajuki marked this pull request as ready for review April 23, 2022 22:46
@Shirajuki Shirajuki changed the title Fixes #40: Project/code cleanup Final pull request go PRRRRR (#40, #56, #64): Project/code cleanup and refactor + skin system Apr 23, 2022
@Shirajuki Shirajuki added this to In progress in Star Battle NTNU via automation Apr 23, 2022
@Shirajuki Shirajuki moved this from In progress to Review in progress in Star Battle NTNU Apr 23, 2022
kavusiks
kavusiks approved these changes Apr 24, 2022
View reviewed changes
Copy link
Collaborator

@kavusiks kavusiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Star Battle NTNU automation moved this from Review in progress to Reviewer approved Apr 24, 2022
@kavusiks kavusiks merged commit b77af76 into master Apr 24, 2022
Star Battle NTNU automation moved this from Reviewer approved to Done Apr 24, 2022
@kavusiks kavusiks deleted the code-cleanup branch April 24, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavusiks kavusiks kavusiks approved these changes

@WilliamHLe WilliamHLe Awaiting requested review from WilliamHLe

@TorbsT TorbsT Awaiting requested review from TorbsT

@HeleneAmlie HeleneAmlie Awaiting requested review from HeleneAmlie

@FabioSavio FabioSavio Awaiting requested review from FabioSavio

@macmikke macmikke Awaiting requested review from macmikke

Assignees

@Shirajuki Shirajuki

Labels
None yet
Projects
Star Battle NTNU
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skin system for ships Loose two hearts Project cleanup
2 participants
@Shirajuki @kavusiks