Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing identifiers to lua_string! #4

Closed
wants to merge 1 commit into from
Closed

Allow passing identifiers to lua_string! #4

wants to merge 1 commit into from

Conversation

JoshPiper
Copy link
Contributor

As title, allows passing identifiers as well as string literals, such as is used in gm_sysinfo

Unfortunately, however, the macro has not been tested to ensure operability, however, similar code is already used in larger macros, so it shouldn't be an issue.

@WilliamVenner
Copy link
Owner

I think this will be confusing to use.

let a = 50;
lua_string!(a) // Does the user expect a Lua string of "50", or "a"?

@JoshPiper
Copy link
Contributor Author

Hmm, hadn't considered that. Perhaps some sort of implementable type later down the line would be more appropriate then.

@JoshPiper JoshPiper closed this Dec 31, 2021
@JoshPiper JoshPiper deleted the macro/lua-str-from-ident branch December 31, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants