Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is src or srcset the right solution? #64

Closed
marcoscaceres opened this issue Oct 8, 2012 · 3 comments

Comments

@marcoscaceres
Copy link
Contributor

commented Oct 8, 2012

For the picture element's source children, @marcosc changed the spec so that the src attribute now accepts an image candiate string.

However, @Wilto has argued this is could prove to be confusing to developers:

I’m not sure about this change, considering that we’re introducing some serious deviation to a long-established attribute—this isn’t a markup pattern that applies to any other use of src, which I find a little strange.
Plus, this is behavior and syntax already handed by the “existing” srcset attribute. I think this stands to muddy the waters a bit, and I’m not sure what the benefits would be.

@yoavweiss also pointed out that it means redefining input type of an attribute (which could also be problematic from an implementation perspective, but we are not sure - we need more implementation feedback).

@attiks

This comment has been minimized.

Copy link

commented Oct 8, 2012

My 2cents: I would stick with srcset, for the same reason as @Wilto. Is it more difficult to introduce srcset, than redefining src?

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2012

@attiks the thing is, people can still do everything they need to do without need of srcset. srcset was only really introduced because the img element doesn't have a media attribute.

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2012

Ok, we reached consensus on IRC. The solution is to get the srcset spec to work with <source>. That way, we don't need to specify it separately. Also, it means that <picture><source src> can continue to happily.

@Wilto Wilto closed this Oct 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.