Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Windspigot doesn't support Protocollib 5.0 #46

Closed
Hyronymos1337 opened this issue May 22, 2022 · 14 comments
Closed

Windspigot doesn't support Protocollib 5.0 #46

Hyronymos1337 opened this issue May 22, 2022 · 14 comments
Labels
bug Something isn't working

Comments

@Hyronymos1337
Copy link

Describe the bug
We use Protocollib 5.0 to spawn NPCs, with Pandaspigot it works, with WindSpigot it only works with Protocollib 4.0

Bug on latest
Bugg exist son latest WindSpigot

To Reproduce
we can help debbuging it via WindSpigot Discord or Privat (Hyronymos 🥝#6898)

Expected behavior
No Errors

@windcolor-dev windcolor-dev added the bug Something isn't working label May 22, 2022
@windcolor-dev
Copy link
Member

windcolor-dev commented May 22, 2022

Can you post your NPC spawn code and the errors?

@Hyronymos1337
Copy link
Author

@windcolor-dev
Copy link
Member

So the NPC that should spawn doesn't appear at all?

@Hyronymos1337
Copy link
Author

yes

@windcolor-dev
Copy link
Member

Can you post the part of your NPC code that actually sends the packets?

@Hyronymos1337
Copy link
Author

should be this: https://paste.twerion.net/uzabegeloy.typescript

@windcolor-dev
Copy link
Member

Can you show the "sendPacket" method in your "Reflections" class?

@totKing
Copy link

totKing commented May 22, 2022

@windcolor-dev
Copy link
Member

https://paste.twerion.net/dexogilaqu.typescript

Isn't that code for 1.18? Also, doesn't that code just use NMS instead of ProtocolLib to send packets?

@Sculas
Copy link

Sculas commented May 22, 2022

^ Not only that, why are you using both ProtocolLib and NMS? Using both makes no sense, it's like having 2 dependencies that do the same.

@totKing
Copy link

totKing commented May 22, 2022

https://paste.twerion.net/dexogilaqu.typescript

Isn't that code for 1.18? Also, doesn't that code just use NMS instead of ProtocolLib to send packets?

Sry, wrong class pulled from the 1.18 version xd

https://paste.twerion.net/ekofexizen.typescriptd

@windcolor-dev
Copy link
Member

So what's incompatible? Does sending packets via NMS not work while using ProtocolLib 5.0?

@Hyronymos1337
Copy link
Author

Hyronymos1337 commented May 22, 2022

So what's incompatible? Does sending packets via NMS not work while using ProtocolLib 5.0?

probaly both

^ Not only that, why are you using both ProtocolLib and NMS? Using both makes no sense, it's like having 2 dependencies that do the same.

doenst matter, we dont have the issue on native paper 1.8.8, flamepaper, pandaspigot or on 1.18.2 forks

@windcolor-dev
Copy link
Member

Can you elaborate on your problem? I don't understand what the issue is.

@windcolor-dev windcolor-dev closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants