Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger Menu DisplayMode #1381

Closed
JerryNixon opened this issue Jan 11, 2017 · 3 comments
Closed

Hamburger Menu DisplayMode #1381

JerryNixon opened this issue Jan 11, 2017 · 3 comments
Labels

Comments

@JerryNixon
Copy link
Member

This does not work

    <Controls:HamburgerMenu x:Name="MyHamburgerMenu"
                            VisualStateNormalDisplayMode="Inline"
                            VisualStateNarrowDisplayMode="Inline"
                            VisualStateWideDisplayMode="Inline"
                            >

And it should.

@JerryNixon JerryNixon added the bug label Jan 11, 2017
@edyg023
Copy link

edyg023 commented Jan 13, 2017

I can verify that this isn't working. Any idea when this will be fixed and when it will be pushed out into a new package?

@dg2k
Copy link

dg2k commented Jan 16, 2017

Unless we are working on a different codebase, the above works for me. Of course, you need to make PaneWidth adjustment in response to DisplayModeChanged event which was obvious when we were working on VisualStateXXXXDisplayMode and related DPs.

As an aside, I see no reason why Inline would be used with VisualStateNarrowDisplayMode when OverLay is more appropriate. I see Inline (or CompactInline) where screen space is not an issue (e.g., desktop) while Overlay where screen space is at a premium (e.g., mobile).

UPDATE: Checked with HamburgerMenu project and it works, even with a Mobile Emulator.

@JerryNixon
Copy link
Member Author

JerryNixon commented Feb 5, 2017

@dg2k paste ges your HamMenu XAML for me, pls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants