-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitLocalize - emoji or unicode? #113
Comments
I merged them in Polish, because I wasn't thinking about it at that time, and it was a pull request, not allowing me to directly change it. I think, in general, it would be better to have the actual emojis, so they are visible while translating. The issue is that, as you said, it would be nice to have it consistent with English.json, but unfortunately, changing There also might be a good reason why DevilXD uses unicode. So, my main question would be: Do you guys want to use Unicode or emojis directly? Why?For added context, GitLocalize shows the emoji even if the file has Unicode. If you change the string that includes Unicode in GitLocalize, it changes the Unicode to an Emoji, which is how we ended up here. |
Maybe for inventory tab it's have sense to use emoji, but i never see when on main tab this emojes shows as colored. |
@kilroy98 There should be no difference at runtime, and when compiled, it might even be exactly the same. The only difference is how it looks in the source file. While GitLocalize seems to continually want to convert it to the actual emoji and most editors support it, something like vim or other cli based editors will show � or □, because terminals often have a limited font, that doesn't include emoji. |
I changed the emoticons to Unicode because that's it maked in the English translation.
TwitchDropsMiner-updated/lang/English.json
Lines 96 to 98 in 662711c
TwitchDropsMiner-updated/lang/English.json
Lines 119 to 125 in 662711c
And you merged changes like this in polish translation - 1c1203a
The text was updated successfully, but these errors were encountered: