Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLocalize - emoji or unicode? #113

Open
kilroy98 opened this issue Jun 10, 2024 · 3 comments
Open

GitLocalize - emoji or unicode? #113

kilroy98 opened this issue Jun 10, 2024 · 3 comments
Labels
Feedback Wanted Extra feedback is needed Translation Stuff related to translations or english descriptions

Comments

@kilroy98
Copy link

kilroy98 commented Jun 10, 2024

I changed the emoticons to Unicode because that's it maked in the English translation.

"online": "ONLINE \u2714",
"pending": "OFFLINE \u23f3",
"offline": "OFFLINE \u274c",

"linked": "Linked \u2714",
"not_linked": "Not Linked \u274c",
"active": "Active \u2714",
"upcoming": "Upcoming \u23f3",
"expired": "Expired \u274c",
"claimed": "Claimed \u2714",
"ready_to_claim": "Ready to claim \u23f3"

And you merged changes like this in polish translation - 1c1203a

@Windows200000 Windows200000 added the Feedback Wanted Extra feedback is needed label Jun 10, 2024
@Windows200000
Copy link
Owner

Windows200000 commented Jun 10, 2024

@kilroy98

And you merged changes like this in polish translation

I merged them in Polish, because I wasn't thinking about it at that time, and it was a pull request, not allowing me to directly change it.

I think, in general, it would be better to have the actual emojis, so they are visible while translating.

The issue is that, as you said, it would be nice to have it consistent with English.json, but unfortunately, changing English.json would mark all affected translations as incomplete in GitLocalize, requiring quite a painstaking process of removing and adding all languages back manually.

There also might be a good reason why DevilXD uses unicode.

So, my main question would be:

Do you guys want to use Unicode or emojis directly? Why?

For added context, GitLocalize shows the emoji even if the file has Unicode. If you change the string that includes Unicode in GitLocalize, it changes the Unicode to an Emoji, which is how we ended up here.

@Windows200000 Windows200000 added the Translation Stuff related to translations or english descriptions label Jun 10, 2024
@Windows200000 Windows200000 changed the title About changes on gitlocalize GitLocalize - emoji or unicode? Jun 10, 2024
@kilroy98
Copy link
Author

kilroy98 commented Jun 11, 2024

Maybe for inventory tab it's have sense to use emoji, but i never see when on main tab this emojes shows as colored.

@Windows200000
Copy link
Owner

Windows200000 commented Jun 11, 2024

@kilroy98 There should be no difference at runtime, and when compiled, it might even be exactly the same.

The only difference is how it looks in the source file. While GitLocalize seems to continually want to convert it to the actual emoji and most editors support it, something like vim or other cli based editors will show � or □, because terminals often have a limited font, that doesn't include emoji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Wanted Extra feedback is needed Translation Stuff related to translations or english descriptions
Projects
None yet
Development

No branches or pull requests

2 participants