Add a refresh method to the RouterService #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `refresh` method to the RouterService as described in RFC 631 RFC PR: emberjs/rfcs#631
|
@Windvis Possible we can upstream this to Ember.js now? |
|
@snewcomer Hey! Can you elaborate on what you mean with "upstream this to Ember.js"? 😅 If you mean moving the implementation into Ember itself that is already the case and the feature is enabled in 4.1.0-beta.1. If you mean moving this polyfill to the ember-polyfills org, I've asked around in the Discord already but it seems that everyone is busy 😄. |
|
Oh thank you! I may have been looking at 3.28 and should have been looking at the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
refreshmethod to the RouterService as described in RFC 631RFC PR: emberjs/rfcs#631