Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added webpack with typescript #9

Closed
wants to merge 1 commit into from

Conversation

NielsFestjens
Copy link
Contributor

@NielsFestjens NielsFestjens commented Jan 12, 2022

The game is now an npm package, which means you need to install the dependencies by running "npm install"
The game can now be started by running the command "npm start".
It uses webpack dev server, which has a bonus of automatically reloading JS and CSS changes.
I added Typescript, so when you reference a property that doesn't exist, you get compiler errors (and much more).
It has already shown me some bugs, which are now fixed.
Have a look, play around, and tell me if you like it!

@Winnrman
Copy link
Owner

I see what you're trying to do here, but the npm is not necessary because its a web game, as well as the typescript conversion is a big change which isn't really needed. The project is not at the level where TypeScript would actually be an advantage over JS.

@Winnrman Winnrman closed this Jan 13, 2022
@NielsFestjens
Copy link
Contributor Author

Just shedding some light: it's an npm package so we can manage dependencies through npm, not to publish it on npm or anything like that.
There might be a big change in the infrastructure, but you'll notice the contents of the files haven't really changed a lot, except for some minor changes (including bug fixes, found through TypeScript errors!).
But I can understand, it's a new technology to add to the project and that can be a bit scary.
I'll try to move the bug fixes to a new pull request.

@NielsFestjens NielsFestjens deleted the typescript branch January 16, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants