Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protodune wire geometry v3 has order errors #2

Closed
brettviren opened this issue May 13, 2019 · 0 comments
Closed

protodune wire geometry v3 has order errors #2

brettviren opened this issue May 13, 2019 · 0 comments

Comments

@brettviren
Copy link
Member

Induction wires with segment 1 are wrongly ordered in protodune-wires-larsoft-v3.json.bz2

The intention is that all wires are always ordered such that (wire)X(pitch) = (face normal) where normal points into the drift volume (ie, anti-parallel to drift direction).

The v3 sorting used the simple assumption that wire-center should increase in (local) Z. This works for MB but fails on segment-1 wires in DUNE SP as the segment-1 wires have degenerate Z values.

This bug will hit any code that relies on this ordering. In particular, fast spatial lookup of nearest wire in the sim and similar calculations in imaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant