Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang and dynamic_pointer_cast #5

Closed
brettviren opened this issue Oct 11, 2018 · 0 comments
Closed

Clang and dynamic_pointer_cast #5

brettviren opened this issue Oct 11, 2018 · 0 comments

Comments

@brettviren
Copy link
Member

At the core of WCT is the NamedFactory which provides object construction and lookup based on a component "type" (not C++ type) and an "instance" name. For this to work a dynamic_pointer_cast of the shared pointers must work.

Apparently there's some dark art related to this. It's worked for years for many versions of GCC but now Clang is being tested at 5.0.1 causes the test_dlopen test to fail.

A search finds this issue: android/ndk#533 and indeed moving inline desctructors out of the header and into an implementation file lets this test pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant