Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop staticcheck (honnef.co/go/tools) from go.mod require list #118

Closed
stv0g opened this issue Feb 8, 2022 · 2 comments
Closed

Drop staticcheck (honnef.co/go/tools) from go.mod require list #118

stv0g opened this issue Feb 8, 2022 · 2 comments
Assignees
@mdlayher

Comments

@stv0g
Copy link
Contributor

stv0g commented Feb 8, 2022 •
edited
Loading

I realized that adding wgctrl as a dependency to my go package pulls in honnef.co/go/tools and as transitive dependency.

From my understanding this package is only used to pin a specific staticcheck version.

I find it quite unconventional to use the go.mod file for this purpose.
At least I haven't seen in any other go package so far.

Can we remove this dependency alongside the tools.go file?
@mdlayher
Copy link
Member

mdlayher commented Feb 8, 2022

Yep, this is something I had tried out briefly but have been removing from other projects. Will do.

@mdlayher mdlayher self-assigned this Feb 8, 2022
@stv0g
Copy link
Contributor Author

stv0g commented Feb 8, 2022

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdlayher mdlayher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stv0g @mdlayher