Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting root folder in LocalFileSystemHandler #288

Closed
muzammilkm opened this issue Jun 20, 2019 · 7 comments
Closed

Allow setting root folder in LocalFileSystemHandler #288

muzammilkm opened this issue Jun 20, 2019 · 7 comments

Comments

@muzammilkm
Copy link

Exapnding LocalFileSystemHandler by taking root path for admin mapping, can help reuse LocalFileSystemHandler.

A constructor taking root path & we can set overloaded to settings.FileSystemHandler

private readonly string _rootFolder;

LocalFileSystemHandler()
{
    rootFolder = Directory.GetCurrentDirectory();
}

LocalFileSystemHandler(string rootFolder)
{
    _rootFolder = rootFolder;
}

Changes in GetMappingFolder

public string GetMappingFolder()
{
   return Path.Combine(_rootFolder, AdminMappingsFolder);
}
@StefH
Copy link
Collaborator

StefH commented Jun 20, 2019

You can try preview:
WireMock.Net.1.0.21-ci-11468

@StefH
Copy link
Collaborator

StefH commented Jun 20, 2019

BTW I see that you have added a NuGet WireMock, this is done because of above request ?

@muzammilkm
Copy link
Author

muzammilkm commented Jun 20, 2019

BTW I see that you have added a NuGet WireMock, this is done because of above request ?

No, that's not mine, but one of my colleague who published without consulting me & i would ask him to drop that package and this is not an appropriate way.

@StefH
Copy link
Collaborator

StefH commented Jun 20, 2019

OK, if you can ask him to unlist the package, that would be great. Else users can be confused.

Did you have time to test latest WireMock.Net.1.0.21-ci-11468 ? Is it working for you?

@muzammilkm
Copy link
Author

Thanks,
Verified in (1.0.21-ci-11471)

@StefH
Copy link
Collaborator

StefH commented Jun 20, 2019

Ok. Thanks. Closing this one.

@StefH StefH closed this as completed Jun 20, 2019
@StefH
Copy link
Collaborator

StefH commented Jul 3, 2019

#286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants