Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be a .NET 5.0 target now? #541

Closed
gitfool opened this issue Nov 24, 2020 · 4 comments
Closed

Should there be a .NET 5.0 target now? #541

gitfool opened this issue Nov 24, 2020 · 4 comments
Labels

Comments

@gitfool
Copy link
Contributor

gitfool commented Nov 24, 2020

After porting projects to .NET 5.0, unit and integration tests using WireMock.Net seem to work fine, apart from logging "WireMock.Net server using .NET Core 3.1". Not sure when it's needed but I noticed there are a lot of target frameworks for some reason:

Specify:

<TargetFrameworks>net451;net452;net46;net461;netstandard1.3;netstandard2.0;netstandard2.1;netcoreapp3.1</TargetFrameworks>

Also, some of those are now well out of support and so could possibly be dropped?

@StefH
Copy link
Collaborator

StefH commented Nov 26, 2020

#543

@StefH
Copy link
Collaborator

StefH commented Nov 26, 2020

Hello @gitfool,

  • Can you explain this: WireMock.Net seem to work fine, apart from logging ?
  • Some frameworks are indeed out of support, however for now I keep these. Probably next year I will remove some.

@gitfool
Copy link
Contributor Author

gitfool commented Nov 26, 2020

@StefH the logging comes from the hard wired log message determined by target framework at compile time (AspNetCoreSelfHost .RunHost), which you address in PR 543 along with a few other tweaks that make me think a new release with net5.0 target framework is advisable.

@StefH
Copy link
Collaborator

StefH commented Nov 28, 2020

OK.
PR is merged

@StefH StefH closed this as completed Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants