chore: add notice to readme #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierchow
reviewed
Jan 9, 2020
README.md
Outdated
|
|
||
| - since version 1.0.0 the default vaule of `stale` was set to `ok` in viewQuery. | ||
|
|
||
| If the update condition field isn't `id` you must put `stale` in `options` parameter to make sure you get the correct data, like: |
There was a problem hiding this comment.
Suggested change
| If the update condition field isn't `id` you must put `stale` in `options` parameter to make sure you get the correct data, like: | |
| If the update condition field isn't `id` you might need to set `stale` in `options` parameter to make sure you get the latest data if you have a strong need of data instant consistency, like: |
There was a problem hiding this comment.
I think stale must be set to 1 in a write operation. Otherwise, the dirty read and dirty write would happen.
There was a problem hiding this comment.
k, I got you, you are talking about write, LGTM.
chore: rename History.md to History-obsoleted.md
xavierchow
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.