Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with examples #2

Closed
jonchengkuo opened this issue Feb 25, 2022 · 4 comments
Closed

Some issues with examples #2

jonchengkuo opened this issue Feb 25, 2022 · 4 comments
Assignees

Comments

@jonchengkuo
Copy link

Hi Ushakov,

I like your WebApiToolkit. I found a few minor issues on the project home page (https://github.com/Wissance/WebApiToolkit):

  1. In the Requirements section, "labrary" is misspelled.
  2. In the GroupController example, the class constructor name is incorrect.
  3. It'll be better if you can shown how the GroupEntity class implements IModelIdentifiable.

I also have the following comments on WebApiToolkit:

  1. Base Controller: I personally think that passing the Manager object into the base controller via a constructor is easier to understand.
    i.e., public GroupController(GroupManager manager) : base(manager) { }

  2. Order of type parameters is inconsistent between base controller and base manager.
    BasicReadController<GroupDto, GroupEntity, int>
    ModelManager<GroupEntity, GroupDto, int>

Joncheng

@EvilLord666
Copy link
Member

@jonchengkuo , thank you for useful project review. I'll correct documentation asap and also i'll make example project without WebApiToolkit and with it. And also i will clarify order of base classes template paramters. Thank you.

@EvilLord666 EvilLord666 self-assigned this Mar 22, 2022
@EvilLord666
Copy link
Member

@jonchengkuo , I've prepared a full example how to use (whole solution) you could check it here: https://github.com/Wissance/WeatherControl

@EvilLord666
Copy link
Member

Readme updated using examples from link above

@EvilLord666
Copy link
Member

Examples were updated and show full Controller && Manager clases, for reasonable notes created to issues: #6 , #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants