Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters not working when using complex filters #41

Closed
sebastian-jansson opened this issue Mar 17, 2021 · 5 comments
Closed

Parameters not working when using complex filters #41

sebastian-jansson opened this issue Mar 17, 2021 · 5 comments
Assignees

Comments

@sebastian-jansson
Copy link

sebastian-jansson commented Mar 17, 2021

Description of the Issue

When adding parameters to certain filter expressions (Whether that's through templates or direct ones), the parameter gets blank space characters added to it, rendering it useless as jailer won't recognize it as a parameter anymore , with a failed export as the result.
image

I noticed that this bug is only visible when opening the expression editor (Apart from the error log output), viewing it "inline" or directly displays the parameter correctly:

image

I attempted many different combinations, (My real filter expressions has lots of concatenation operators), but even simple ones as the example above fails. The only expressions I could get consistent working results with are ones where the full expression is solely the parameter name itself.

Other things that did not help:

  • Adding the parameter from the sidebar instead of typing it out.
  • Only using the parameter once instead of twice as in my full expression.
  • Different naming standards did not resolve the issue. In fact, it happens for the default "old-value" parameter as well.

Expected Behavior

At save, runtime & edit, one expects the parameter to stay the way it was written out when closing the editor.

Actual Behavior

Parameters are changed into: $ { to_plc_id } from: ${to_plc_id}.

Debug Information

Windows 10 1909
Jailer 10.3.5

@sebastian-jansson
Copy link
Author

sebastian-jansson commented Mar 17, 2021

Forgot to add, when replacing the parameter in the filter expression with the actual value I'm assigning the parameter, I can export the data successfully.

@Wisser Wisser self-assigned this Mar 17, 2021
@Wisser
Copy link
Owner

Wisser commented Mar 17, 2021

Thanks for the report. I will have a look at it as soon as possible.

@sebastian-jansson
Copy link
Author

Thanks for the report. I will have a look at it as soon as possible.

Many thanks Wisser!

@Wisser
Copy link
Owner

Wisser commented Mar 18, 2021

The reason for this was that the SQL formatter unfortunately inserted spaces in awkward places.
I have corrected this and published the fix in release 10.4.

@sebastian-jansson
Copy link
Author

That was quick! Thanks a bunch., I'll download 10.4 and give it a try :)

I'm already loving this tool, has saved me a bunch of time for moving data around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants