Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json output missing detections #59

Closed
56616c6f72 opened this issue Feb 7, 2022 · 3 comments
Closed

Json output missing detections #59

56616c6f72 opened this issue Feb 7, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@56616c6f72
Copy link
Collaborator

Yo yo,

It's your boy, Mert.

Was just testing the json output. It looks like built-in detections do not get appended to the json output. Was this by design or a bug?

Json output:
image

Normal output:
image

@ecapuano
Copy link

Just checking in on this as I am experiencing the same issue. Stdout reports 71 detections, but JSON only contains 42. However, my JSON does contain some of the builtin detections, just not all of them. This may be resolved by the same bug fix, but just bringing it to your attention.

Any progress on a fix? Hoping to get this Velociraptor artifact patched ASAP as it relies on the incomplete JSON results at this time.

image

@alexkornitzer
Copy link
Contributor

Due to the complexity of how builtins work and the required breaking changes to then expose this in the JSON. I am going to resolve this in the v2 work, but i cant give a timeframe for when i will have time to finish it off. Although i have done the bulk of the work already.

@alexkornitzer
Copy link
Contributor

Right this is solved in v2.0.0-alpha.x so am closing this out. Feed back on the output format should be given in #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants