Fix 0.6 bug and julia 0.6 CI testing #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evanmiller Ok, this looks good, the one CI failure is a false alarm, I think the build just was interrupted by something. Would be fantastic if you could merge this and tag a version in METADATA soon, I'm trying to bring together a whole software stack in this field for my juliacon presentation which is coming up soon! |
|
@evanmiller Great, thanks! Could you also tag a release and register that in METADATA.jl? There is a new way to do this: https://github.com/attobot/attobot. You enable it for this repo, and then you just have to create a git tag and push it and make it a release here, the whole process is super smooth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets wait for the CI builds before we merge this, I only tested this on julia 0.6, but we should make sure it also works on julia 0.5.