Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPC] Val'Kyr Herald ID: 37098 Missing Spell on all difficulties. #5042

Closed
Drostthehunter opened this issue Oct 13, 2020 · 10 comments
Closed
Assignees
Labels
Fixed on PTR - Tester Confirmed The proposed fix has been confirmed to be working in PTR.
Milestone

Comments

@Drostthehunter
Copy link

Links:
https://www.wowhead.com/npc=37098/valkyr-herald
https://www.wowhead.com/spell=71906/severed-essence
https://www.youtube.com/watch?v=AXkAFHXOlJs&ab_channel=zosalvo

What is Happening:
Currently Val'Kyr Herald (37098) does not cast an ability called Severed Essence.

What Should happen:
Val'Kyrs should be able to cast this spell on all difficulties of the raid, 10normal/heroic 25normal/heroic, Severed Essences are the souls ripped appart from the body of the raid members, they are attacking the raid and healing the Valkyr, they are Undead type which means they are stunnable via Holy Wrath. Ignoring the essences is not possible as long as they are alive Val'Kyr keeps on healing herself. Youtube link posted from 2010. is a proof that spell used to exist.

@Drostthehunter Drostthehunter changed the title [NPC] Val'Kyr Herald ID: 37098 Missing Spell on difficulties [NPC] Val'Kyr Herald ID: 37098 Missing Spell on all difficulties. Oct 13, 2020
@jeyrella
Copy link

jeyrella commented Oct 13, 2020

Has been reported before
#4814
#4449
#1330

We have made a lot of changes since then though to the spell systems; will check with @Keader if the landscape has changed for us to be able to fix this (and with jani if this qualifies as a reasonable fix)

@Keader Keader self-assigned this Oct 13, 2020
@bLeyaa
Copy link

bLeyaa commented Oct 13, 2020

Currently the valkyrs are as good as dummies, if the changes in spell system now allow this to be added it will completely change the encounter against them. I know its a "fix in icc" but this would be really nice addition. :)

@Keader
Copy link
Collaborator

Keader commented Oct 13, 2020

I Will only look It in the weekend
Until there, check If janitor approve It @jeyrella

@wow-mania
Copy link
Collaborator

This is starting to piss me off really.
Last one on this once this is closed I will be automatically close any issue around this.

@wow-mania wow-mania modified the milestones: Release 112, Release 114 Oct 21, 2020
@Keader Keader added Developer is on it Fixed on PTR - Ready to Test A fix for this issue has been applied and ready for test in Dev/PTR. and removed Developer is on it labels Oct 26, 2020
@Keader
Copy link
Collaborator

Keader commented Oct 27, 2020

try now pls

@Oganku
Copy link

Oganku commented Oct 27, 2020

Creates copies of all raid players in range with fixed hp and melee damage. Stars aggro'd with the original copy, but has 0 threat so can be aggro'd by anyone else.
The damage from the adds don't seem to scale. Damage is around 9k per hit on a naked toon. The melee damage is far greater than ability damage for all of them. Melee attacks comprise about 80% of their damage overall.

Uses the following for each class:

Druid: Nothing
Warrior: Mortal Strike and Heroic Strike
Death Knight: Necrotic Strike and Plague Strike
Shaman: Lightning Bolt
Warlock: Rain of Chaos/Corruption/Shadow Bolt
Paladin: Radiance Aura and Flash of Light
Rogue: Sinister Strike and Eviscerate
Hunter: Melees and uses Mortal Strike and Heroic Strike...?
Priest: Renew and Greater Heal
Mage: Fireball and Frost Nova (doesn't root or damage)

The summoning script and mob AI seems great though.
The summons do not disappear after the valkyr dies, and do need to be killed afterwards still. Probably intended, just making sure.

@bLeyaa
Copy link

bLeyaa commented Oct 27, 2020

Intended on the last part, they need to be killed separately.
Sounds great so far, well done Keader!

@Keader
Copy link
Collaborator

Keader commented Oct 27, 2020

yes, they should not vanish after vlakyr dies.
checking your complanings now.

@Keader
Copy link
Collaborator

Keader commented Oct 27, 2020

"Hunter: Melees and uses Mortal Strike and Heroic Strike...?"

Fixed melee, but i cant reproduce this mortal strike/heroic strike bug.

Rest of issues, fixed.

@svijetlo
Copy link

WoWScrnShot_102720_152928
WoWScrnShot_102720_152958
WoWScrnShot_102720_153007
WoWScrnShot_102720_153028
WoWScrnShot_102720_153103
this is some good thisng nice job , ss are only form paly tested with rogue , boomy dk , priest hunter , as seen close need to be killed on its own wont be gone ones walk die

@svijetlo svijetlo added Fixed on PTR - Tester Confirmed The proposed fix has been confirmed to be working in PTR. and removed Confirmed - Improvement needed Fixed on PTR - Ready to Test A fix for this issue has been applied and ready for test in Dev/PTR. labels Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed on PTR - Tester Confirmed The proposed fix has been confirmed to be working in PTR.
Projects
None yet
Development

No branches or pull requests

7 participants