Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: options page doesn't work on Firefox for Android #122

Closed
WofWca opened this issue Sep 15, 2022 · 2 comments
Closed

fix: options page doesn't work on Firefox for Android #122

WofWca opened this issue Sep 15, 2022 · 2 comments
Assignees
@WofWca
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@WofWca
Copy link
Owner

WofWca commented Sep 15, 2022

A review said this, and I have managed to reproduce: https://addons.mozilla.org/addon/jump-cutter/reviews/1871616/

I don't know what's this caused by. Here's how to debug on Android.

Also need to see if it's related to #120.

Related: #65.
@WofWca WofWca added the good first issue Good for newcomers label Sep 15, 2022
@WofWca WofWca added the bug Something isn't working label Jan 2, 2023
@WofWca
Copy link
Owner Author

WofWca commented Apr 29, 2023

The problem seems to be on this line:

jumpcutter/src/entry-points/options/App.svelte

Line 53 in 5f434fd

const commandsPromise = browser.commands.getAll();

It says ".commands is undefined"

@WofWca WofWca self-assigned this Apr 29, 2023
@WofWca
Copy link
Owner Author

WofWca commented Apr 29, 2023

Fixed in bd85951

@WofWca WofWca closed this as completed Apr 29, 2023
@WofWca WofWca mentioned this issue Apr 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WofWca WofWca

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WofWca