Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open popup" (Ctrl + Shift + Space) shortcut pauses the video on YouTube #170

Open
WofWca opened this issue May 13, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@WofWca
Copy link
Owner

WofWca commented May 13, 2024

I didn't used to be the case I think like a year ago.

I suspect this is related to the fact that if you execute the shortcut (press the keys), then keypress and keydown events are not dispatched to currently open tab, but keyup does. Try it:

document.addEventListener('keydown', console.log)
document.addEventListener('keyup', console.log)
document.addEventListener('keypress', console.log)

Workaround

Keep "Spacebar" down until the popup gets opened.

Solution

Should probably report this to Chromium or what?

An alternative is to use a different key (not space). Ctrl + Shift + X is meh. I think it's already occupied in Firefox. Though what's wrong with having them different in Firefox and Chromium?

@WofWca WofWca added the bug Something isn't working label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant