Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: use different volumeThreshold for different algorithms #70

Open
WofWca opened this issue Jun 3, 2022 · 1 comment
Open
Labels
good first issue Good for newcomers

Comments

@WofWca
Copy link
Owner

WofWca commented Jun 3, 2022

Margins are already on the list.

algorithmSpecificSettings: {
[ControllerKind.CLONING]: {
marginBefore: 0.050,
marginAfter: 0.030,
},
[ControllerKind.STRETCHING]: {
...stretchingControllerSpecificDefaults,
},
},

Also maybe silenceSpeed also needs to be added there, although it's not used in the cloning algorithm yet.

The reason I think we need this is because with the cloning algorithm you don't really need to set volumeThreshold as low as possible because marginBefore actually works properly there without any stretching.

@WofWca WofWca added the good first issue Good for newcomers label Jun 3, 2022
@WofWca
Copy link
Owner Author

WofWca commented Aug 16, 2022

Oh BTW maybe we should simply make the one setting a multiplier of another setting? E.g. when you switch to the cloning algorithm, just multiply margins by two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant